Skip to content

Clean Code for terminal/bundles/org.eclipse.terminal.connector.process#2723

Open
eclipse-platform-bot wants to merge 2 commits into
masterfrom
clean-code/terminal/bundles/org.eclipse.terminal.connector.process
Open

Clean Code for terminal/bundles/org.eclipse.terminal.connector.process#2723
eclipse-platform-bot wants to merge 2 commits into
masterfrom
clean-code/terminal/bundles/org.eclipse.terminal.connector.process

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

@eclipse-platform-bot eclipse-platform-bot commented Jun 5, 2026

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Jun 5, 2026 •
edited
Loading

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 03519da09e8b1e449acc456983058cbad73f765e Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 8 Jun 2026 07:38:07 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF b/terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF
index 4026ee5efe..580834f6a4 100644
--- a/terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF
+++ b/terminal/bundles/org.eclipse.terminal.connector.process/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.terminal.connector.process;singleton:=true
-Bundle-Version: 1.1.0.qualifier
+Bundle-Version: 1.1.100.qualifier
 Bundle-Activator: org.eclipse.terminal.connector.process.internal.UIPlugin
 Bundle-Vendor: %providerName
 Import-Package: org.eclipse.cdt.utils.pty;mandatory:=native,
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Test Results

    54 files  ±0      54 suites  ±0   59m 8s ⏱️ + 6m 45s
 4 671 tests ±0   4 638 ✅  - 11   22 💤 ±0  2 ❌ +2  9 🔥 +9 
11 907 runs  ±0  11 743 ✅  - 11  153 💤 ±0  2 ❌ +2  9 🔥 +9 

For more details on these failures and errors, see this check.

Results for commit aa3d509. ± Comparison against base commit bd58498.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/terminal/bundles/org.eclipse.terminal.connector.process branch from a6a23aa to 55fd164 Compare June 6, 2026 05:06
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/terminal/bundles/org.eclipse.terminal.connector.process branch from 731dba4 to dcc5c4e Compare June 8, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eclipse-platform-bot